raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8b6e72bfad9d620c17e8e5195a002251d667d10c

commit 8b6e72bfad9d620c17e8e5195a002251d667d10c
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Sat Jul 29 10:52:29 2017 +0900

    els box - remove rudundant double check
    
    not a bug but checking something twice in a row isn't too useful
    
    found by PVS studio
---
 src/lib/elementary/els_box.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/els_box.c b/src/lib/elementary/els_box.c
index 03f418f050..199b739cf0 100644
--- a/src/lib/elementary/els_box.c
+++ b/src/lib/elementary/els_box.c
@@ -278,13 +278,13 @@ _smart_extents_calculate(Evas_Object *box, 
Evas_Object_Box_Data *priv, int w, in
              evas_object_size_hint_max_get(opt->obj, &mnw, &mnh);
              if (mnh >= 0)
                {
-                  if (mnh >= 0) mnh += pad_t + pad_b;
+                  mnh += pad_t + pad_b;
                   if (maxh == -1) maxh = mnh;
                   else if (maxh > mnh) maxh = mnh;
                }
              if (mnw >= 0)
                {
-                  if (mnw >= 0) mnw += pad_l + pad_r;
+                  mnw += pad_l + pad_r;
                   if (maxw == -1) maxw = mnw;
                   else if (maxw > mnw) maxw = mnw;
                }

-- 


Reply via email to