raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2d4d836018387470b5df2c59119ab6cc81188e94

commit 2d4d836018387470b5df2c59119ab6cc81188e94
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Mon Jul 31 10:41:39 2017 +0900

    elm gesture layer - use fabs not abs when actually comparing floats
    
    2 abs uses should have been fabs as they compe a src float with
    anot her float.
    
    found by PVS studio
    
    @fix
---
 src/lib/elementary/elm_gesture_layer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_gesture_layer.c 
b/src/lib/elementary/elm_gesture_layer.c
index 38af0fdf3a..3a29734216 100644
--- a/src/lib/elementary/elm_gesture_layer.c
+++ b/src/lib/elementary/elm_gesture_layer.c
@@ -2530,8 +2530,8 @@ _momentum_test(Evas_Object *obj,
         st->line_end.y = pe_local.y;
         st->t_end = pe_local.timestamp;
 
-        if ((abs(st->info.mx) > ELM_GESTURE_MINIMUM_MOMENTUM) ||
-            (abs(st->info.my) > ELM_GESTURE_MINIMUM_MOMENTUM))
+        if ((fabs(st->info.mx) > ELM_GESTURE_MINIMUM_MOMENTUM) ||
+            (fabs(st->info.my) > ELM_GESTURE_MINIMUM_MOMENTUM))
           state_to_report = ELM_GESTURE_STATE_END;
         else
           state_to_report = ELM_GESTURE_STATE_ABORT;

-- 


Reply via email to