raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=968e1dfb3728a9d630fd5596484f1973ae997ca1

commit 968e1dfb3728a9d630fd5596484f1973ae997ca1
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Mon Jul 31 12:18:00 2017 +0900

    elocation - fix return of status, address, position to actually ret data
    
    the data was never returned! fix fix fix.
    
    found by PVS studio
    
    @fix
---
 src/lib/elocation/elocation.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/elocation/elocation.c b/src/lib/elocation/elocation.c
index 79cd1255f5..dc00a00aa1 100644
--- a/src/lib/elocation/elocation.c
+++ b/src/lib/elocation/elocation.c
@@ -1119,7 +1119,7 @@ elocation_address_get(Elocation_Address *address_shadow)
    if (!address) return EINA_FALSE;
    if (address == address_shadow) return EINA_TRUE;
 
-   address_shadow = address;
+   *address_shadow = *address;
    return EINA_TRUE;
 }
 
@@ -1130,7 +1130,7 @@ elocation_position_get(Elocation_Position 
*position_shadow)
    if (!position) return EINA_FALSE;
    if (position == position_shadow) return EINA_TRUE;
 
-   position_shadow = position;
+   *position_shadow = *position;
    return EINA_TRUE;
 }
 
@@ -1141,7 +1141,7 @@ elocation_status_get(int *status_shadow)
    if (status < 0) return EINA_FALSE;
    if (&status == status_shadow) return EINA_TRUE;
 
-   status_shadow = &status;
+   *status_shadow = status;
    return EINA_TRUE;
 }
 

-- 


Reply via email to