discomfitor pushed a commit to branch enlightenment-0.21.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=e386143e43a06a43c1e63aa242c613494e1663af

commit e386143e43a06a43c1e63aa242c613494e1663af
Author: Mike Blumenkrantz <[email protected]>
Date:   Fri Aug 25 14:47:04 2017 -0400

    use clone of remembers list in window remember config
    
    this modifies the remember list and guarantees a crash if sorting occurs
---
 src/modules/conf_window_remembers/e_int_config_remembers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/modules/conf_window_remembers/e_int_config_remembers.c 
b/src/modules/conf_window_remembers/e_int_config_remembers.c
index 82e6dc599..c8e315c37 100644
--- a/src/modules/conf_window_remembers/e_int_config_remembers.c
+++ b/src/modules/conf_window_remembers/e_int_config_remembers.c
@@ -207,7 +207,7 @@ _fill_remembers(E_Config_Dialog_Data *cfdata)
    e_widget_ilist_freeze(cfdata->list);
    e_widget_ilist_clear(cfdata->list);
 
-   ll = e_config->remembers;
+   ll = eina_list_clone(e_config->remembers);
    ll = eina_list_sort(ll, -1, _cb_sort);
 
    ic = e_icon_add(evas);
@@ -279,6 +279,7 @@ _fill_remembers(E_Config_Dialog_Data *cfdata)
    e_widget_ilist_thaw(cfdata->list);
    edje_thaw();
    evas_event_thaw(evas);
+   eina_list_free(ll);
 
    e_widget_disabled_set(cfdata->btn, 1);
 }

-- 


Reply via email to