jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=706cf9c48824352014fe1827a8dffbfca912f6fd
commit 706cf9c48824352014fe1827a8dffbfca912f6fd Author: Jean-Philippe Andre <[email protected]> Date: Tue Sep 19 18:51:58 2017 +0900 elm: Fix invalid uses of Efl.Orientation I think this closes the orientation vs. direction problem. RTL vs. AnyRTL is not fully handled yet but this becomes a widget-per-widget issue (eg. should a box in a RTL locale be mirrored if set to horizontal?). Fixes T5870 --- src/examples/elementary/clock_example.js | 2 +- src/lib/elementary/efl_ui_layout_pack.c | 8 ++++---- src/lib/elementary/efl_ui_layout_part_box.eo | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/examples/elementary/clock_example.js b/src/examples/elementary/clock_example.js index c15a54d63e..94eef0e136 100644 --- a/src/examples/elementary/clock_example.js +++ b/src/examples/elementary/clock_example.js @@ -9,7 +9,7 @@ bx = new efl.Efl.Ui.Box(win); bx.setHintWeight(1.0, 1.0); win.setContent(bx); bx.setVisible(true); -bx.setOrientation(efl.Efl.Orient.VERTICAL); +bx.setDirection(efl.Efl.Dir.VERTICAL); ck = new efl.Elm.Clock(win); bx.packEnd(ck); diff --git a/src/lib/elementary/efl_ui_layout_pack.c b/src/lib/elementary/efl_ui_layout_pack.c index f002a34f33..b77ebf7333 100644 --- a/src/lib/elementary/efl_ui_layout_pack.c +++ b/src/lib/elementary/efl_ui_layout_pack.c @@ -255,12 +255,12 @@ _efl_ui_layout_part_box_efl_pack_linear_pack_index_get(Eo *obj EINA_UNUSED, Efl_ ELM_PART_RETURN_VAL(efl_pack_index_get(pack, subobj)); } -EOLIAN static Efl_Orient -_efl_ui_layout_part_box_efl_orientation_orientation_get(Eo *obj EINA_UNUSED, Efl_Ui_Layout_Box_Data *pd) +EOLIAN static Efl_Ui_Dir +_efl_ui_layout_part_box_efl_ui_direction_direction_get(Eo *obj EINA_UNUSED, Efl_Ui_Layout_Box_Data *pd) { - ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, EFL_ORIENT_NONE); + ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, EFL_UI_DIR_DEFAULT); - ELM_PART_RETURN_VAL(efl_orientation_get(efl_part(wd->resize_obj, pd->part))); + ELM_PART_RETURN_VAL(efl_ui_direction_get(efl_part(wd->resize_obj, pd->part))); } diff --git a/src/lib/elementary/efl_ui_layout_part_box.eo b/src/lib/elementary/efl_ui_layout_part_box.eo index a0e72964f6..02e2be0e90 100644 --- a/src/lib/elementary/efl_ui_layout_part_box.eo +++ b/src/lib/elementary/efl_ui_layout_part_box.eo @@ -1,5 +1,5 @@ class Efl.Ui.Layout.Part.Box (Efl.Object, Efl.Pack.Linear, - Efl.Orientation) + Efl.Ui.Direction) { [[Represents a Box created as part of a layout. @@ -22,7 +22,7 @@ class Efl.Ui.Layout.Part.Box (Efl.Object, Efl.Pack.Linear, Efl.Container.content_iterate; Efl.Container.content_count; Efl.Container.content_remove; - Efl.Orientation.orientation { get; } + Efl.Ui.Direction.direction { get; } Efl.Pack.pack_clear; Efl.Pack.unpack_all; Efl.Pack.unpack; --
