stefan pushed a commit to branch elementary-1.7.
commit 04ad875c1f4568489dcd58d75178d29580f0ba07
Author: Stefan Schmidt <[email protected]>
Date: Thu Jun 13 16:25:14 2013 +0100
elm_gesture_layer: Fix potential NULL pointer dereference.
If _pointer_even_make is false pe stays NULL and might get dereferenced
later. Instead we return now if _pointer_event_make fails.
Thanks to Tom for consulting with the gesture layer code.
---
src/lib/elm_gesture_layer.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c
index 9fdacf1..b85b266 100644
--- a/src/lib/elm_gesture_layer.c
+++ b/src/lib/elm_gesture_layer.c
@@ -1323,8 +1323,10 @@ _event_process(void *data,
ELM_GESTURE_LAYER_DATA_GET(data, sd);
/* Start testing candidate gesture from here */
- if (_pointer_event_make(data, event_info, event_type, &_pe))
- pe = &_pe;
+ if (!_pointer_event_make(data, event_info, event_type, &_pe))
+ return;
+
+ pe = &_pe;
/* Test all the gestures */
{
--
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
