devilhorns pushed a commit to branch master.
commit c04cfde0e5ac391c9006df5410f8314f9d7cce4f
Author: Chris Michael <[email protected]>
Date: Mon Jul 8 11:17:13 2013 +0100
Fix mem leak reported by Coverity: If we fail to create a new internal
menu, then free the previously allocated xml file.
NB: Fixes Coverity CID 1039182
Signed-off-by: Chris Michael <[email protected]>
---
src/lib/efreet/efreet_menu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/lib/efreet/efreet_menu.c b/src/lib/efreet/efreet_menu.c
index fa04616..feea57d 100644
--- a/src/lib/efreet/efreet_menu.c
+++ b/src/lib/efreet/efreet_menu.c
@@ -569,7 +569,11 @@ efreet_menu_parse(const char *path)
/* split apart the filename and the path */
internal = efreet_menu_internal_new(NULL);
- if (!internal) return NULL;
+ if (!internal)
+ {
+ efreet_xml_del(xml);
+ return NULL;
+ }
internal->efreet_merged_menus = eina_hash_string_superfast_new(NULL);
internal->efreet_merged_dirs = eina_hash_string_superfast_new(NULL);
--
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
