raster pushed a commit to branch master.
commit aede39bc544d8a92dcf3e001b35562a7d1f10db9
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date: Fri Aug 9 17:48:31 2013 +0900
elm popup leak fix! also in notify!
---
src/lib/elc_popup.c | 13 +++++++++++++
src/lib/elm_notify.c | 1 +
2 files changed, 14 insertions(+)
diff --git a/src/lib/elc_popup.c b/src/lib/elc_popup.c
index f08e656..852cb78 100644
--- a/src/lib/elc_popup.c
+++ b/src/lib/elc_popup.c
@@ -228,6 +228,19 @@ _elm_popup_smart_del(Eo *obj, void *_pd, va_list *list
EINA_UNUSED)
_list_del(sd);
}
+ // XXX? delete other objects? just to be sure.
+ ELM_SAFE_FREE(sd->notify, evas_object_del);
+ ELM_SAFE_FREE(sd->title_icon, evas_object_del);
+ ELM_SAFE_FREE(sd->content_area, evas_object_del);
+ ELM_SAFE_FREE(sd->text_content_obj, evas_object_del);
+ ELM_SAFE_FREE(sd->action_area, evas_object_del);
+ ELM_SAFE_FREE(sd->box, evas_object_del);
+ ELM_SAFE_FREE(sd->tbl, evas_object_del);
+ ELM_SAFE_FREE(sd->spacer, evas_object_del);
+ ELM_SAFE_FREE(sd->scr, evas_object_del);
+ ELM_SAFE_FREE(sd->content, evas_object_del);
+ ELM_SAFE_FREE(sd->title_text, eina_stringshare_del);
+
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
}
diff --git a/src/lib/elm_notify.c b/src/lib/elm_notify.c
index a43d573..46c361a 100644
--- a/src/lib/elm_notify.c
+++ b/src/lib/elm_notify.c
@@ -462,6 +462,7 @@ _elm_notify_smart_del(Eo *obj, void *_pd, va_list *list
EINA_UNUSED)
elm_notify_allow_events_set(obj, EINA_FALSE);
if (sd->timer) ecore_timer_del(sd->timer);
+ ELM_SAFE_FREE(sd->notify, evas_object_del);
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
}
--
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
