seoz pushed a commit to branch master.

commit 4021be2295b2ccbb2c16b9d2fba666ab6c8523c0
Author: Daniel Juyung Seo <[email protected]>
Date:   Sun Aug 11 17:13:17 2013 +0900

    elm_prefs.c: dereference variable in a proper place.
    
    This fixes coverity CID 1040034 : Dereference after null check 
(FORWARD_NULL).
---
 src/lib/elm_prefs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_prefs.c b/src/lib/elm_prefs.c
index e3a2d20..92139d3 100644
--- a/src/lib/elm_prefs.c
+++ b/src/lib/elm_prefs.c
@@ -959,8 +959,8 @@ _elm_prefs_page_load(Evas_Object *obj,
 
         if (!ret)
           ERR("problem while reading from file %s, key %s", sd->file, pname);
-
-        ret->prefs = obj;
+        else
+          ret->prefs = obj;
      }
    else
      ERR("failed to load from requested epb file (%s)", sd->file);

-- 

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk

Reply via email to