On Sat, 9 Feb 2013 16:53:29 +0530 Arvind R <[email protected]> said:
these are in svn now for sure. these are good.
> Hi,
> 1. remove __UNUSED__ for parameter that is used.
>
> diff -uprN a/src/lib/elc_player.c b/src/lib/elc_player.c
> --- a/src/lib/elc_player.c 2012-11-26 14:59:01.000000000 +0530
> +++ b/src/lib/elc_player.c 2013-02-01 19:54:22.000000000 +0530
> @@ -398,7 +398,7 @@ _str_free(char *data)
> * layout */
>
> static void
> -_elm_player_smart_content_set(Eo *obj, void *_pd EINA_UNUSED, va_list *list)
> +_elm_player_smart_content_set(Eo *obj, void *_pd, va_list *list)
> {
> const char *part = va_arg(*list, const char *);
> Evas_Object *content = va_arg(*list, Evas_Object *);
>
>
> 2. emit a "elm,player,play" signal as is done in _pause to keep the
> state of pause/play buttons in sync.
>
> diff -uprN a/src/lib/elc_player.c b/src/lib/elc_player.c
> --- a/src/lib/elc_player.c 2013-02-09 00:57:30.000000000 +0530
> +++ b/src/lib/elc_player.c 2013-02-09 00:58:16.000000000 +0530
> @@ -249,6 +249,7 @@ _play(void *data,
> {
> ELM_PLAYER_DATA_GET(data, sd);
>
> + elm_layout_signal_emit(data, "elm,player,play", "elm");
> elm_video_play(sd->video);
> elm_layout_signal_emit(data, "elm,button,play", "elm");
> evas_object_smart_callback_call(data, SIG_PLAY_CLICKED, NULL);
>
>
> 3. Correct double_to_string which misses out subtracting hours to get seconds.
>
> diff -uprN a/src/lib/elc_player.c b/src/lib/elc_player.c
> --- a/src/lib/elc_player.c 2013-02-09 01:00:18.000000000 +0530
> +++ b/src/lib/elc_player.c 2013-02-09 02:01:25.000000000 +0530
> @@ -372,7 +372,7 @@ _double_to_time(double value)
>
> ph = value / 3600;
> pm = value / 60 - (ph * 60);
> - ps = value - (pm * 60);
> + ps = value - (pm * 60) - (ph * 3600);
> pf = value * 100 - (ps * 100) - (pm * 60 * 100) - (ph * 60 * 60 * 100);
>
> if (ph)
>
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> enlightenment-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-users
>
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
enlightenment-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-users
