On Mon, Sep 22, 2014 at 08:20:10PM +0200, Jehan Pagès wrote: > Hi, > > I'm writing some code in Entangle, and I see this in > entangle_pixbuf_loader_load() [src/backend/entangle-pixbuf-loader.c]: > > if (hasPixbuf && 0) > do_idle_emit(loader, "pixbuf-loaded", image); > if (hasMetadata && 0) > do_idle_emit(loader, "metadata-loaded", image); > > Why is the signal emission disabled when the pixbuf was already loaded > after a load request? > In my current code, I need to wait for several images to be loaded at > some point. There may be already loaded (and if so, great, I don't > have to wait) or not, but I would still like to receive the signal. > Was there any reason to this 0? Was it making any problem somewhere > else in the code?
Looking at the current entangle-camera-manager.c code where I receive the signal, it would cause us to re-set the pixbuf on the EntangleImage object which would possibly trigger a needless redraw. Just try enabling the signal and see if there's any obvious ill-effects. This code has gone through several iterations, most recently I removed most use of threading, so it is possible this is just obsolete code that doesn't cause a problem anymore. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Entangle-devel mailing list Entangle-devel@gna.org https://mail.gna.org/listinfo/entangle-devel
