On 8/18/2016 2:23 PM, [email protected] wrote:
On 7/14/2016 4:51 PM, [email protected] wrote:
On 7/12/2016 8:52 AM, Kaply Consulting wrote:
That's weird. The code is exactly the same:
https://dxr.mozilla.org/mozilla-central/source/browser/components/distribution.js?q=browser.showpersonaltoolbar&redirect_type=single#457
And it worked in my testing
I'm packaging 48.0.1 for internal distribution and had a moment to take
another look at this.
I looked over the link you provided again and noticed that "collapsed"
is the key (not sure if that's the right word) for 'showMenubar' and
also for 'PersonalToolbar'. Yet, when I look at xulstore.json I see that
the key is "collapsed" for 'PersonalToolbar', but is instead "autohide"
for 'toolbar-menubar'.
Is it intentional that those be different from each other or should the
"keys" (again, not sure of the right word) be the same?
Just tested with version 49.0.2 and found that the behavior is the same.
Having this in INSTALL_DIR\defaults\profile\xulstore.json works:
{
"chrome://browser/content/browser.xul":
{
"toolbar-menubar":
{
"autohide":"false"
}
}
}
Having this in INSTALL_DIR\distribution\distribution.ini (and without
the above entry in xulstore.json) does not:
browser.showMenubar=true
When I look at the distribution.js code:
https://dxr.mozilla.org/mozilla-central/source/browser/components/distribution.js?q=browser.showpersonaltoolbar&redirect_type=single#457
I find this:
var showMenubar =
Services.prefs.getBoolPref("browser.showMenubar");
if (showMenubar) {
xulStore.setValue(BROWSER_DOCURL, "toolbar-menubar",
"collapsed", "false");
}
Should that be setting a value for 'autohide' instead of 'collapsed'?
_______________________________________________
Enterprise mailing list
[email protected]
https://mail.mozilla.org/listinfo/enterprise
To unsubscribe from this list, please visit https://mail.mozilla.org/listinfo/enterprise
or send an email to [email protected] with a subject of
"unsubscribe"
