2013/8/19 Claudio Saavedra <csaave...@gnome.org>: > On Mon, 2013-08-19 at 11:19 +0800, 藍挺瑋 wrote: >> Hi! >> >> I have sent 12 patches to bugzilla: >> https://bugzilla.gnome.org/show_bug.cgi?id=705599 > > Great, thank you! > >> These patches implement archives extraction. Are these patches too >> many? What should I do after uploading these patches? > > The number of patches is not important. What matters is that each patch > implements an atomic change that can be tested independently and that > each patch in the sequence depends only on previous patches. > > Also, if there are refactorings or bug fixes that are independent from > your work and could be integrated separately, it would be preferable to > attach them to new bug reports. > > I have not reviewed your patches yet so I don't know whether that's the > case, but I wanted to answer your question. I hope this helps. > >> I do not start working on archives creation in Epiphany because I >> cannot think of a way to do this. It seems uploading is handled in >> WebKit, and I don't know how to create an archive only on demand. > > I am not sure what do you mean with archive creation in the context of > Epiphany? Do you mean, allowing an user to create an archive when trying > to upload a file to a webpage (for instance, when attaching a file in > gmail)? > > If that's the case, maybe GtkFileChooser would be the right place? >
The problem is that creating an archive may take a lot of time. I think creating an archive after GtkFileChooser is completed is the only way. However, users have to wait until the archive is created. If just creating the archive asynchronously, WebKit may report wrong information to the web page. > Claudio > > _______________________________________________ > epiphany-list mailing list > epiphany-list@gnome.org > https://mail.gnome.org/mailman/listinfo/epiphany-list _______________________________________________ epiphany-list mailing list epiphany-list@gnome.org https://mail.gnome.org/mailman/listinfo/epiphany-list
