Mykola,

I think the changes by itself are ok. It gives people more flexibility in 
building. The relative paths "../../../" only work when all clients using that 
property are at the same level. There should be a note on the property. This 
makes it tough to use. But I don't think there is a restructuring planned 
anytime soon. ;)

However, the Jenkins layout example is something I'd advice against. This kind 
a makes one Jenkins job depending on what's going on in another Jenkins job 
without making it obvious. It introduces a door for hidden dependency side 
effects. Instead I would recommend going with a build pipeline, which allows 
checking out two Git repositories in a single build. This ensures consistency 
and also allows chained/staged building. It also prevents the hidden side 
effect.

-Gunnar

-- 
Gunnar Wagenknecht
[email protected], http://guw.io/


> On Apr 5, 2019, at 10:17, Mykola Nikishov <[email protected]> wrote:
> 
> Hi,
> 
> Initially, to build rt.equinox.framework/pom.xml with native launchers
> using Tycho, you have to put source code of rt.equinox.binaries into a
> specific location:
> 
> - rt.equinox.framework and rt.equinox.binaries must share the same
>  parent folder
> - rt.equinox.framework expects rt.equinox.binaries' directory name
>  exactly as 'rt.equinox.binaries'
> 
> In other words, the only supported layout is:
> 
>    /path/to/rt.equinox.framework/
>    /path/to/rt.equinox.framework/.git
>    /path/to/rt.equinox.binaries/
>    /path/to/rt.equinox.binaries/.git
> 
> but not:
> 
>    /path/to/equinox/framework/ <- job's workspace root
>    /path/to/equinox/framework/sources/
>    /path/to/equinox/framework/sources/.git
>    /path/to/equinox/framework/.repository/
>    /path/to/equinox/binaries/ <- job's workspace root
>    /path/to/equinox/binaries/sources/
>    /path/to/equinox/binaries/sources/.git
>    /path/to/equinox/binaries/.repository/
> 
> I use such layout on Jenkins, where project's source code and
> per-project Maven local repository are different directories.
> 
> [1] is the 3rd (and I think, the last) step that would relax
> these restrictions and will make second case work.
> 
> [1] https://git.eclipse.org/r/139803
> [2] https://git.eclipse.org/r/136176
> [3] https://git.eclipse.org/r/139593
> 
> -- 
> Mykola
> 
> Libre/Free Java Software Developer
> https://manandbytes.gitlab.io/
> 
> _______________________________________________
> equinox-dev mailing list
> [email protected]
> To change your delivery options, retrieve your password, or unsubscribe from 
> this list, visit
> https://www.eclipse.org/mailman/listinfo/equinox-dev

_______________________________________________
equinox-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://www.eclipse.org/mailman/listinfo/equinox-dev

Reply via email to