Reviewed, tested, and accepted. Going to message you privately about publishing. I am having an issue.
Thanks! JW On Sun, Apr 3, 2011 at 10:22 PM, Jordan Wilberding <[email protected]>wrote: > I will review right now. > > As for the eunit test, I am not sure. You will probably have to ask Eric. > I'd like to be on that call if possible as well to make sure I understand > what he did. > > Thanks! > JW > > > On Sun, Apr 3, 2011 at 7:26 PM, Martin Logan <[email protected]>wrote: > >> Can someone review the ewl_file module I have submitted into >> erlware_commons. I have endeavoured to have most functions return >> exceptions upon not functioning which also has the nice advantage of >> making these functions easily composible with others as in >> >> binary_to_list(ec_file:read(File)). >> >> I have added an ehanced exception macro as well. This is something we >> can either use in other modules or abandon as a practice. the module >> provides for the formatting of a nicer error message as well as module >> and line number. That info can be removed when Erlang R15b comes out. >> >> We currently have over 70% unit test coverage on the module. The >> testing could perhaps use some enhancement. I see what Eric did with >> the find test and perhaps that is the way to go. I don't understand >> what was done though so that could be an area where someone can >> explain to me this more advanced and unfamiliar use of eunit. >> >> Cheers, >> Martin >> >> -- >> Martin Logan >> Erlang & OTP in Action (Manning) http://manning.com/logan >> http://twitter.com/martinjlogan >> http://erlware.org >> >> -- >> You received this message because you are subscribed to the Google Groups >> "erlware-dev" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/erlware-dev?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "erlware-dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/erlware-dev?hl=en.
