It looks like we are a bit adhok right now. ec_file has a defined exception format, but it is private to ec_file. At the very least we need to be consistant across erlware commons modules. I have cut an issue for this in erlware/erlware_commons on github. Hopefully we can get to fixing it soonish.
On Thu, Apr 21, 2011 at 12:28 PM, Eric Merritt <[email protected]> wrote: > Understood on the exceptions, its more encouragement then anything else. > > On the standard for exceptions, go back in history and take a look. We had a > long conversation like a month ago on the topic. I am not too worried about > ciconia or any other app that is not intended to be consumed as a library. I > am more concerned about erlware_commons and those that are designed to be > consumed as libraries. I think having consumable standard well documented > exceptions are important there. > > Eric > >>On Apr 21, 2011 11:49 AM, "Martin Logan" <[email protected]> wrote: > >> I am ok with the exception documentation, I think a standard for that >> is a good idea. Though, exceptions travel through the stack, and so >> there will be misses when a low level function throws an exception and >> higher level ones dont. This should be noted in the standard. >> >> Secondly, I would have to see the standard for exceptions. I already >> have one in Ciconia and I am not looking to change it so this standard >> should be a SHOULD not a MUST. >> >> On Thu, Apr 21, 2011 at 9:51 AM, Eric Merritt <[email protected]> >> wrote: >>> in function docs, since there is no support in specs for exceptions yet. >>> >>> On Thu, Apr 21, 2011 at 9:40 AM, Jordan Wilberding >>> <[email protected]> wrote: >>>> Documented in code or in docs? >>>> JW >>>> >>>> On Thu, Apr 21, 2011 at 9:01 AM, Eric Merritt <[email protected]> >>>> wrote: >>>>> >>>>> Guys, >>>>> >>>>> I think we should add a couple of things to the standards. First and >>>>> formost, if an exception can occure it should be documented so it can >>>>> be caught and handled. The second is we should write up this exception >>>>> stuff we talked about last month and start using it. Assuming there is >>>>> no objecting I will do this for commons and sinan. >>>>> >>>>> Eric >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups >>>>> "erlware-dev" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]. >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/erlware-dev?hl=en. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups >>>> "erlware-dev" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/erlware-dev?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "erlware-dev" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/erlware-dev?hl=en. >>> >>> >> >> >> >> -- >> Martin Logan >> Erlang & OTP in Action (Manning) http://manning.com/logan >> http://twitter.com/martinjlogan >> http://erlware.org >> >> -- >> You received this message because you are subscribed to the Google Groups >> "erlware-dev" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/erlware-dev?hl=en. >> > -- You received this message because you are subscribed to the Google Groups "erlware-dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/erlware-dev?hl=en.
