Hi Christian,
Wauw fixed an issue without knowing it cool, sure I can merge my change into 
the ClientMessageBusImpl like you suggest.
I'll add a demo like you suggest and make it and add some dependencies as the 
next steps. Look forward to some more pull requests.

Cheers,
        Erik Jan

> Hi Erik,
> 
> Your LocationAwareClientMessageBus actually fixes an existing problem we have 
> only partially addressed so far: Setting the remote bus endpoint 
> programatically (see https://issues.jboss.org/browse/ERRAI-380). 
> 
> So, I think we could even add this to the ClientMessageBusImpl directly and 
> default to getApplicationRoot() if no custom Configuration was found. 
> 
> Wdyt? 
> 
> Making gwt-phonegap a dependency of errai-cordova sounds fine to me. Example 
> setups and demos could also live under errai-cordova/demos. That's how we set 
> it up for errai-bus/errai-cdi/ etc.
> 
> Cheers,
> Christian
> 


_______________________________________________
errai-dev mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/errai-dev

Reply via email to