On Thu, Feb 23, 2012 at 12:18 PM, Domenic Denicola < [email protected]> wrote:
> Perhaps using indexOfIdentical from > http://wiki.ecmascript.org/doku.php?id=harmony:simple_maps_and_sets > +1. If they want the behavior that's broken on -0.0 and NaN in the traditional way, I don't think that there's enough difference between saying if (arr.contains(foo)) { vs if (arr.indexOf(foo) !== -1) { to justify adding a new API, whether a new method or a new type. However, because fixing indexOf is not on the table, and I'd hate to introduce a parallel similar-but-different indexOfIdentical method as standard, if we're going to add any contains method as standard, it should not be similarly broken. ________________________________________ > From: [email protected] [[email protected]] on > behalf of Erik Arvidsson [[email protected]] > Sent: Thursday, February 23, 2012 15:15 > To: [email protected] > Subject: Array.prototype.contains > > DOM4 added a new interface called DOMStringList for the sole reason > that Array does not have contains. Before this the return type was an > Array of Strings so we could use indexOf, map, forEach etc. Now that > it is using a non Array we lost all of that. > > Proposal: Add Array.prototype.contains, implemented as: > > Object.defineProperty(Array.prototype, 'contains', { > value: function(value) { > return this.indexOf(value) !== -1; > }, > enumerable: false, > configurable: true, > writable: true > }{); > > > This is trivial enough to do in user code but since DOM4 depends on it > we should just put it in the right place; In ES6. > > -- > erik > _______________________________________________ > es-discuss mailing list > [email protected] > https://mail.mozilla.org/listinfo/es-discuss > > > _______________________________________________ > es-discuss mailing list > [email protected] > https://mail.mozilla.org/listinfo/es-discuss > -- Cheers, --MarkM
_______________________________________________ es-discuss mailing list [email protected] https://mail.mozilla.org/listinfo/es-discuss
