Excellent, great work. From private correspondence with Sencha, it seems
they may be able to avoid the problem without too much trouble.
Still, a bitter stab in the back from 'with'! And cautionary for future
method additions (not that I propose mangled or unlikely names).
/be
Brian Terlson wrote:
I have a dataset of scripts downloaded from the top 10k websites by traffic
according to Alexa. These scripts are static only, and from page-load only, so
take this information with the appropriate amount of salt.
I searched for occurrences of the identifiers "keys", "values", or "entries" inside with
statements. Only one site (rank 2243 as of 6 months ago) was found in this query. It contains the identifier
"keys" in a with statement, but won't be broken as the with object is appears to always be an instance of
Object not Array.
I also searched for all occurrences of eval inside with statements. 24 sites
(lowest rank, #19 - ebay.com) matched this query. A random sample of 5 sites
found that in all cases the with object was instance of Object.
I could dig in more if people are interested. Let me know!
-----Original Message-----
From: [email protected] [mailto:[email protected]] On
Behalf Of Claude Pache
Sent: Wednesday, June 19, 2013 12:48 AM
To: Brandon Benvie; Jason Orendorff
Cc: [email protected]
Subject: Re: Array.prototype.values() compatibility hazard
Le 18 juin 2013 à 03:30, Brandon Benvie<[email protected]> a écrit :
On 6/17/2013 4:33 PM, Jason Orendorff wrote:
Firefox added Array.prototype.values() and immediately ran into compatibility
issues.
https://bugzilla.mozilla.org/show_bug.cgi?id=883914
https://bugzilla.mozilla.org/show_bug.cgi?id=881782
Both bug reports have to do with Sencha Ext JS. I haven't looked closely yet.
It seems `with(values)` appears in Ext.
-j
Looks like the `with` is responsible. When the "values" there is an array, any reference inside the
`with` to "values" then becomes "values.values".
Note that they should look after `with(anyArray)` rather than `with(values)`,
in order to resolve that issue.
-Claude
_______________________________________________
es-discuss mailing list
[email protected]
https://mail.mozilla.org/listinfo/es-discuss
_______________________________________________
es-discuss mailing list
[email protected]
https://mail.mozilla.org/listinfo/es-discuss
_______________________________________________
es-discuss mailing list
[email protected]
https://mail.mozilla.org/listinfo/es-discuss
