On Tue, Jan 21, 2014 at 9:06 PM, Gustavs Tēbergs <fixplzsecr...@gmail.com>wrote:

> On 22 January 2014 01:50, Sean Silva <sil...@purdue.edu> wrote:
> > Your `load` routine is not how I described and is inducing a ton of
> > cache-busting heap traffic. You need to put *all* strings in a single,
> > constant array and append references to those constant strings to a
> single
> > growing array. There should be no concatenations except for the final
> > .join(). I.e. something like:
>
> I think that's what it already does. Using += is faster than
> push-and-join in isolated tests. I could cache uses of num.toString()
> though.
>

I'm not so worried about that. Rather, it is all the temporary string that
are being created. For example, the single line ` app( getIdent(read16()) +
'[' )` is creating at least 2 temporary strings.

-- Sean Silva
_______________________________________________
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Reply via email to