On Wed Dec 24 2014 at 4:49:36 PM Kevin Smith <[email protected]> wrote:
> Here is the summary: >> Total Files Read: 11038 >> Files Containing Explicit 'enumerable: false': 149 >> Occurrences of 'enumerable: false' (and variants): 206 >> > > I love this kind of analysis - thanks! > I was actually inspired by a similar report you created for the list in the past. > > My interpretation of this data is that non-enumerability isn't important > enough to bother with in the vast majority of cases. > Yes, this was my interpretation as well. > It *may* still be that non-enumerability is the least-surprise option for > class methods, but certainly users don't care enough about the issue > currently to bother with typing in "enumerable: false". > > I'm still concerned about the refactoring hazard argument. I think the > idea is that if I change some ES5-style class into an ES6-style class, then > I need to have good unit tests already in place to make sure that > non-enumerability won't break things. Otherwise, I can't do the refactor. > Agreed: this has also been my main argument when the subject has come up in the past. Rick
_______________________________________________ es-discuss mailing list [email protected] https://mail.mozilla.org/listinfo/es-discuss
