Thanks, Jason. I tried that approach last night (calling setPrototypeOf within the getPrototypeOf trap), and it caused a nasty regression in one of my other prototype-checking tests. I assumed at the time that I had done something wrong, but your quick summary shows that instead I was doing something right, and that my prototype chain handling was incorrectly implemented...
On Tue, May 23, 2017 at 9:26 AM, Jason Orendorff <[email protected]> wrote: > I think the most straightforward thing is something like this: > > https://gist.github.com/jorendorff/85d74ef7dce0118664535f84d57d6788 > > To restate the obvious, this is a minimal fix for your minimized test > case, not production code you can take and use. You'd need to implement all > the rest of the handler methods. > > > On Tue, May 23, 2017 at 11:01 AM, Alex Vincent <[email protected]> > wrote: > >> Yes, I've been using the shadow technique in my es7-membrane project for >> quite some time. I was trying to minimize a fairly complex test case here. >> >> Obviously, I can reintroduce shadow targets into the minimal testcase, >> but then I need to figure out how to make the prototype object I'm trying >> to get consistent again... still working through the details of that in my >> head. >> >> On Tue, May 23, 2017 at 8:50 AM, Mark S. Miller <[email protected]> >> wrote: >> >>> Take a look at Tom's explanation of the "shadow target" technique at >>> https://research.google.com/pubs/pub40736.html >>> section 4.3 >>> >>> -- >>> Cheers, >>> --MarkM >>> >> >> > -- "The first step in confirming there is a bug in someone else's work is confirming there are no bugs in your own." -- Alexander J. Vincent, June 30, 2001
_______________________________________________ es-discuss mailing list [email protected] https://mail.mozilla.org/listinfo/es-discuss
