Marius, Thanks for turning this fix around so quickly!
David On Sun, Nov 15, 2009 at 7:58 AM, Marius <[email protected]> wrote: > > Pushed a fix to master. Please let me if there are other issues here. > > On Nov 15, 2:38 pm, Marius <[email protected]> wrote: > > Pushed a suggested fix on reviewboard > > > > Br's, > > Marius > > > > On Nov 15, 2:24 pm, Marius <[email protected]> wrote: > > > > > What is the exact JS error? > > > > > On Nov 15, 2:04 pm, Marius <[email protected]> wrote: > > > > > > I don't think my commits may have caused this. > > > > > > Derek ? > > > > > > Br's, > > > > Marius > > > > > > On Nov 14, 11:36 pm, David Pollak <[email protected]> > > > > wrote: > > > > > > > Looks like a bug. Please open a ticket athttp:// > github.com/dpp/liftweb/issues > > > > > > > Marius & Derek: could this have anything to do with your recent > changes? If > > > > > so, could you get a fix into the repo, asap? > > > > > > > On Sat, Nov 14, 2009 at 1:31 PM, Richard Hirsch < > [email protected]>wrote: > > > > > > > > I think I might have found a lift bug in the <lift:form> tag > > > > > > > > I just did a update and certain HTML buttons (for example, "Add" > in > > > > > > creating a new action, etc.) no longer work. A javascript syntax > error > > > > > > is thrown. > > > > > > > > The file in question is > > > > > > \trunk\server\src\main\webapp\action_view\index.html. The code is > > > > > > here: > > > > > > > > <div class="ui-tabs-panel ui-widget-content ui-corner-bottom > > > > > > ui-tabs-hide" id="tabs-2"> > > > > > > <lift:form> > > > > > > <lift:main> > > > > > > <table> > > > > > > > > This is code currently generated and which causes the syntax > error. > > > > > > <form id="F1008082309036RKD" action="javascript://" > > > > > > > > > onsubmit="liftAjax.lift_ajaxHandler(jQuery('#'+"F1008082309036RKD").serialize(), > > > > > > , null, "javascript");return false;"> > > > > > > > > This older generated code is currently deployed on stax are works > > > > > > correctly. > > > > > > > > <form id="F444961682037I0I" action="javascript://" > > > > > > > > > onsubmit="liftAjax.lift_ajaxHandler(jQuery('#'+"F444961682037I0I").serialize(), > > > > > > null, null, null);return false;"> > > > > > > > > Notice the difference in the onsubmit value. > > > > > > > > D. > > > > > > > -- > > > > > Lift, the simply functional web frameworkhttp://liftweb.net > > > > > Beginning Scalahttp://www.apress.com/book/view/1430219890 > > > > > Follow me:http://twitter.com/dpp > > > > > Surf the harmonics > --~--~---------~--~----~------------~-------~--~----~ > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected]<liftweb%[email protected]> > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en > -~----------~----~----~----~------~----~------~--~--- > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Surf the harmonics
