Hi Imtiaz, I applied this locally and took a look. There are a couple of issues. But first, thanks for working on this. It looks like there is a lot of progress in this patch and I think most of it will be usable. I think we all appreciate the work you have put into it. I know that I do :-)
The first issue is easy - The patch includes the fix for ESME-205 and it shouldn't. Obviously one way to avoid this happening is to manually specify which files to include in the diff. A better way is probably to use a branch for this type of development. Unfortunately there isn't really a way I'm satisfied with in SVN, and there isn't a way we've settled on in this project, but I'd recommend branching. The second issue is more difficult, and I'm not sure that my preference is correct, however: My preference is that this should not be a modal dialog at all, and instead should be inserted directly into the "My Pools" page. The reason is that I think this is actually the primary information that users will expect to see on the "My Pools" page, and we should not ask them to click again to bring it up. Perhaps the "My Pools" page should be changed to include a single list of all pools that the user is a member of (basically what you have in your modal dialog currently). In this list, perhaps we could have an "Edit" button for pools in which the user has an Admin role. This button might then trigger a modal dialog with the pool-editing interface that currently shows up in the "My Pools" page when the user selects a pool from the drop-down. Was that clear? Do you agree/disagree? If it's not clear, maybe I need to mock it up to show you what I'm thinking. For the modal dialog itself, Can you take a look at the jQuery modal dialogs that Dick set up? An example is when you click the "New" button on the "My Tokens" page. I have no idea how it was done off the top of my head. Maybe you did the same thing, but the one in your patch looks different and we should probably use the same approach for all modal dialogs. Thanks, Ethan On Thu, Aug 12, 2010 at 6:52 AM, Imtiaz Ahmed H E <[email protected]> wrote: > This fix , attached patch EsmeJira108FixPatch.diff, fixes it following the > example in http://demo.liftweb.net/rhodeisland;jsessionid=ojmsqzkop0i. > > Let me know if you need any changes, cosmetic or otherwise... > > Imtiaz > > > ----- Original Message ----- From: "Richard Hirsch" <[email protected]> > To: <[email protected]> > Sent: Sunday, August 08, 2010 10:20 PM > Subject: Re: ESME-214... > > > Container based authentication is the idea that the container (jetty, > tomcat, etc.) is used to authenticate the user rather than using the > ESME internal (Open-ID, username-password) methods. For example, if > container authentication would be active then the user can sign on via > an external corporate single sign on mechanism and then ESME would > take the information from this system and use it as the user id. > > This may be associated with the use of a corporate LDAP. You might > want to take a look at Lift's LDAP support to get an initial > impression of what is necessary. > > Until I get back and do a full spec in JIRA for container-based > authentication, ESME 108 might be easier to work on > > On Sat, Aug 7, 2010 at 1:13 AM, Imtiaz Ahmed H E <[email protected]> > wrote: >> >> Vassil, >> >> I have been tutoring myself just a bit on stuff related to ESME-214, >> container-based authentication, and would you be in a position to tell me >> *exactly* what needs to be done to make this 'resolved/implemented'. I'll >> go ahead and do that and submit a patch to the Jira ticket. >> >> Dick seems to be the originator, and Ethan appears incommunicado for the >> past week ! >> >> Imtiaz >> >> >> ----- Original Message ----- From: "Richard Hirsch" >> <[email protected]> >> To: <[email protected]> >> Sent: Friday, July 16, 2010 4:10 PM >> Subject: Release planning >> >> >>> I've been working on the JIRA items and we have 10 items left for this >>> release. >>> >>> The following items are linked to IE 7: >>> * ESME-207 >>> * ESME-239 >>> * ESME-208 >>> >>> Some of these items are CSS-related (for example, 207) but the other >>> ones are javascript / jquery related. >>> >>> I think the two main issues are: >>> >>> * ESME-205 Search is broken (This only happens when you use a JDBC >>> based compass indexes - first noticed on Stax but it also is present >>> locally) >>> * ESME-212 Messages from pools aren't hidden >>> >>> I'm going to be gone the next four weeks on vacation, so either >>> someone else can coordinate the release or we wait until I return to >>> continue with our release preparations. >>> >>> If anyone wants to work on other items until the release, here are >>> other items that I consider important: >>> >>> * ESME-108 - View my pools" functionality >>> * ESME-170 Pubsubhubbub support for Atom & RSS actions# >>> * ESME-214 Add container-based authentication >>> * ESME-213 Twitter API is out-of-date and API calls don't always >>> return the correct info >>> >>> -- other api2 related changes - see the ToDos at the bottom of the >>> API2.scala page . >>> >>> D. >> >> > >
