[Changed subject to start a new thread. Was: "New issues - a couple of blockers for 1.1 release"]
That's correct. The "Popular messages" functionality just keeps a counter of how many times a message has been resent. If you look at the UserActor.scala, lines 197 & 198, you'll see that the statistic "ResendStat" is incremented when a message is resent, but only if the message is not in a pool. Then when we want to find out what the most popular messages are, we ask the PopStatsActor - for example in the "popular" method of UserSnip.scala - line 213. On the other hand, the "LinkClicked is incremented in UrlStore.scala - line 40. Here there is never a check to see if the link came from a message in a pool. (This counter is used in the "links" method in UserSnip.scala, after the "popular" method.) I think we need to check if a link came from a pool before incrementing the counter, but in order to do this we need to record what pool a link belonged to, so I think we need to make pool part of the key of the UrlStore object and then populate this field when a new link is created. Ethan On Tue, Aug 31, 2010 at 8:11 AM, Imtiaz Ahmed H E <[email protected]> wrote: > In the home when I type in a message sharing it with one pool and click > resend it does not show up in Popular Messages. But if the message is public > it shows up on resend in Popular Pessages. > > Can you explain. Haven't gotten to Popular Links yet. > > Imtiaz > > ----- Original Message ----- From: "Ethan Jewett" <[email protected]> > To: <[email protected]> > Sent: Tuesday, August 31, 2010 11:37 AM > Subject: Re: New issues - a couple of blockers for 1.1 release > > > Hi, > > The issue doesn't happen with Popular Messages, only with Popular Links. > > I need to look into the implementation, but I have a feeling the > Popular Links issue is going to be a headache. I believe that for a > given link there is no way to tell what message it shows up in, which > would make it impossible to tell if it is a link from a pooled message > or not. We may have to modify the data model for storing links to flag > the ones that started out in a pooled message... > > Regarding Pubsubhubbub, as Dick said, there's no hurry. I don't think > I'll be working on it over the next couple of weeks. > > Thanks for all your efforts! > > Ethan > > On Tue, Aug 31, 2010 at 4:20 AM, Imtiaz Ahmed H E <[email protected]> > wrote: >> >> Re https://issues.apache.org/jira/browse/ESME-267 >> >> I haven't tried this but plan to fix it right away. >> >> Tell me, is it only the links showing up in 'Popular Links' or is that a >> problem with the message itself also showing up in 'PopularMessages' >> >> Looks like I'll never get going with pubsubhubub ! First there was Dick's >> Release Planning mail with the pending 1.1 issues and now here are some >> more. Plan to get going after all 1.1 ending issues are resolved. >> >> However, Ethan it was your issue originally and if you feel you want to >> take >> it back again to push it to closure faster or something please do, >> otherwise >> I'll re-start on it once 1.1 is done... >> >> Imtiaz >> >> ----- Original Message ----- From: "Richard Hirsch" >> <[email protected]> >> To: <[email protected]> >> Sent: Monday, August 30, 2010 12:00 AM >> Subject: Re: New issues - a couple of blockers for 1.1 release >> >> >>> On Sun, Aug 29, 2010 at 7:59 PM, Ethan Jewett <[email protected]> wrote: >>>> >>>> Hi all, >>>> >>>> I've created a few new issues in the Jira based on my testing of the >>>> latest Stax deployment as well as some local testing. I see a couple >>>> of them as blockers of the 1.1 release (ESME-266 is definitely >>>> debatable, but I'm pretty adamant about ESME-267 as it's a real >>>> security issue): >>>> >>>> ESME-266 - https://issues.apache.org/jira/browse/ESME-266 - Some >>>> RSS/Atom feeds don't work properly. Normally I would have pushed this >>>> to the backlog, but it makes it so that we can't import Twitter feeds, >>>> which I think is pretty important. >>> >>> +1 >>> >>>> >>>> ESME-267 - https://issues.apache.org/jira/browse/ESME-267 - "Links >>>> from messages in pools show up in "Popular links" for users that are >>>> not in the pool" - I put an example into the ticket of why this is a >>>> big problem >>> >>> +1 - have you tried to see if resending messages in pools has the same >>> problem? >>> >>>> >>>> ESME-268 - https://issues.apache.org/jira/browse/ESME-268 - User >>>> should not be offered the option to "resend" his/her own messages. >>>> This is assigned to release 1.2 as I don't believe it is a major >>>> issue. If it is fixed before Dick tags release 1.1, then I'm in favor >>>> of including it. >>> >>> I agree as well >>> >>> >>> Thanks for checking for bugs. I'm sure after we create a RC and people >>> start testing we will probably find more bugs. >>>> >>>> Ethan >>>> >> >> > >
