I submitted a fix. The problem was in the fixConversation method, which tried to save the newly created message yet again. When a message has been already saved in the DB, it has an ID and this save isn't a problem, because the message is updated. When the message is newly created, it doesn't have a valid ID, so save saves yet another message instead of updating the old one.
Vassil On Tue, Oct 19, 2010 at 6:31 AM, Vassil Dichev <[email protected]> wrote: > An action is not likely to create a duplicate message, as even when it > resends, a new message is never created and the mailbox is checked if > such a message exists. I've solved at least 2 duplication bugs so far > and the problem has always been that the same message was visualized > twice. > > The first thing to look for is the id of the message in the page > source- if the id is the same, then it's the same message shown twice > by the UI. > > I'd like to take a look at the problem and check if I see an easy solution. > > Vassil > > > On Tue, Oct 19, 2010 at 5:32 AM, Richard Hirsch <[email protected]> wrote: >> On Mon, Oct 18, 2010 at 7:30 PM, Ethan Jewett <[email protected]> wrote: >>> No, I don't think so. I did a clean install locally last week and I only >>> have the RSS-pull action set up. It's a ghost in the machine somewhere ;-) I >>> spent some time tracing through actor messaging paths and I guess I'll just >>> need to spend a little more time on it. >>> >>> An alternative would be to find an SVN check-in that doesn't have the issue >>> and then track down the exact change that caused the problem. Not sure which >>> will be more difficult ... >> >> This would probably be a challenge - especially if the problem has >> been around for a while. >> >> D. >>> >>> Ethan >>> >>> On Mon, Oct 18, 2010 at 5:51 PM, Richard Hirsch >>> <[email protected]>wrote: >>> >>>> On Mon, Oct 18, 2010 at 5:41 PM, Ethan Jewett <[email protected]> wrote: >>>> > Hi all, >>>> > >>>> > Dick did some testing after my commits today and found a couple of >>>> issues. >>>> > The first (ESME-290) was that I broke the public timeline. That is now >>>> > fixed. >>>> > >>>> > The second issue is ESME-291 - >>>> > https://issues.apache.org/jira/browse/ESME-291. The problem is that >>>> replies >>>> > show up duplicated in the streams view and in the public timeline view >>>> > (though in the public timeline view it is *only* for messages that were >>>> > created before the public timeline actor started up, so if you create new >>>> > replies you need to restart the server to see them duplicated in the >>>> public >>>> > timeline). This is actually an old issue. It exists at least in release >>>> 1.1 >>>> > and probably well before that. >>>> > >>>> > The reason this is happening is that when a reply is created there are >>>> > actually two messages created and persisted to the database. One is >>>> created >>>> > in the UserActor, which is what is supposed to happen. But another >>>> message >>>> > is created somewhere else and I can't figure out where! Any ideas? >>>> >>>> Some action maybe? >>>> >>>> Maybe Vassil has an idea. >>>> > >>>> > Ethan >>>> > >>>> >>> >> > > > > -- > Twitter: http://twitter.com/vdichev > Blog: http://speaking-my-language.blogspot.com >
