On Mon, May 11, 2009 at 10:07:09PM +0100, Daniel P. Berrange wrote:
> This seems to pass in the main manager window to each of virt-manager's
> other windows, and uses that as the parent of the about dialog. I don't
> see how this will work in scenarios where the main manager window is 
> not visible. If using gnome-terminal, for example with many terminals
How would that be possible? It seems the about dialog can only be called
from the main window (or did I miss something?). Other dialogs that can
be opened from different menus certainly do need more care.

> open, the window simply gets shown above the window I select Help->About
> from, and if you select 'Help -> About' from many windows, it just opens
> one new instance each time. I think this is simpler than trying to keep
> a singleton about window and making it track the manager window.
I do agree iff the dialog in question can be spawned from more than one
window. The main purpose of the patch was to get an idea if using
set_transient_for is the right thing to do.
Cheers,
 -- Guido

_______________________________________________
et-mgmt-tools mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Reply via email to