+1
On 1/14/09 9:32 AM, "Scott Comer (sccomer)" <[email protected]> wrote: > DefaultDeliveryService ends call with mb.CloseDelivery() and it should end it > with mb.CloseRead() > ------------------------------------------------------------------------------ > ------------------- > > Key: ETCH-25 > URL: https://issues.apache.org/jira/browse/ETCH-25 > Project: Etch > Issue Type: Bug > Components: csharp-binding, java-binding > Affects Versions: 1.0.1, 1.0.0 > Reporter: scott comer > > > when done reading the mailbox, the right method to call is CloseRead(). > somehow the code actually calls CloseDelivery(), a method used to shutdown the > writing side of the mailbox. CloseRead() calls CloseDelivery() first off, but > then takes the additional steps of redelivering any messages left in the > mailbox. > > The distinction is rather fine, and this bug was found by reading the source > code. There are certain ways you could exercise this bug, but it would be very > rare and not have any real impact. So, it isn't an emergency to fix it, but it > is also a relatively benign fix. I've already made the change in my tree and > tested it. The patch is attached. > > ------------------ > > there is little risk. all unit tests have passed. > > scott out > > -- James Dixson Manager, Software Development CUAE Engineering, Cisco Systems (e) [email protected] (p) 512-336-3305 (m) 512-968-2116
