Hello Solomon,

Looks good. Small optimization could be:

       snprintf (out_buff, SHORT_STR,
-               "ERP info: 0x%x (%sNon-ERP STAs, %suse protection)",
+               "ERP info: 0x%x (%sNon-ERP STAs, %suse protection,
%slong preambles)",
                tag_data_ptr[0],
                tag_data_ptr[0] & 0x01 ? "" : "no ",
-               tag_data_ptr[0] & 0x02 ? "" : "do not ");
+               tag_data_ptr[0] & 0x02 ? "" : "do not ",
+               tag_data_ptr[0] & 0x04 ? "short or ": "");
       proto_tree_add_string (tree, tag_interpretation, tvb, offset + 2,
                             tag_len, out_buff);
+
       break;

Best regards,

Martijn Schipper
Software Quality Engineer 
Intersil Netherlands BV. 
Rembrandtlaan 1a 
3723 BG  Bilthoven 
The Netherlands 
Tel:    +31 (0)30 2296076 
Fax:    +31 (0)30 2296061 
E-mail:   [EMAIL PROTECTED] 
Internet:  www.intersil.com
 

-----Original Message-----
From: Solomon Peachy [mailto:[EMAIL PROTECTED] 
Sent: dinsdag 1 april 2003 17:07
To: [EMAIL PROTECTED]
Subject: [Ethereal-dev] small update to the 802.11 dissector

This patch adds support for the latest stuff defined in the draft 7.1 of

802.11g, plus a few response codes defined in 802.11b.

Pretty straightforward.

 - Pizza
-- 
Solomon Peachy                        [EMAIL PROTECTED]
AbsoluteValue Systems                 http://www.linux-wlan.com
715-D North Drive                     +1 (321) 259-0737  (office)
Melbourne, FL 32934                   +1 (321) 259-0286  (fax)


Reply via email to