On Tue, 19 Aug 2003, Guy Harris wrote: > On Fri, Aug 15, 2003 at 02:14:16PM -0700, Richard Sharpe wrote: > > A few days ago I sent out email pointing out that the label on the dialog > > box that is displayed when a user clicks on the About Ethereal menu item > > is inconsistent in that it shows up as Ethereal: Information rather than > > About Ethereal. > > > > Having looked at this some further, it seems that the problem is caused by > > the simple_dialog function not taking a label for the dialog box that is > > displayed. > > > > Would people be annoyed if I added a label parameter to simple_dialog? > > I wouldn't be. > > > Of course, this raises the question of what should be done with WARNING or > > CRIT or INFO dialog boxes ... > > Well, they should probably do similar things to other GUIs, although, > unfortunately, I'm currently running FreeBSD/KDE 1.x, and don't have my > other machines/OSes booted so I can't check that. > > Should the About dialog have the warning/error/information icon?
This was my next thought, and then I groaned at the amount of work involved. Firstly, I am going to have to run awk or something over the code to include a CONSTANT label (#defined) in all those calls to simple_dialog all over the code, and then I need to find some icons :-( Regards ----- Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, sharpe[at]ethereal.com, http://www.richardsharpe.com
