On Fri, Oct 18, 2002 at 10:19:00AM -0600, Greg Morris wrote: > You mentioned the get_string function, I have been testing with > modifying nw_uni to set the maximum size for a string to 1024. I have > not found any string that exceeded that length.
Checked in (with the "strcat()" calls changed to "strcpy()", as "strcat()" will only append to what's there, not overwrite it). > Also the changes for allowing SPX to pass to subdissectors is great, > but, Should'nt it first evaluate if there is any additional payload to > pass? That depends on whether there are SPX packets other than data packets to be delivered to a protocol above SPX or not (as is the case with TCP, and as isn't the case with UDP). I infer that this is the case for SPX, so it should do that check. I've checked in a change to check whether there's anything past the SPX header (using "tvb_reported_length_remaining()", so it'll check based on the actual length of the frame, rather than on the amount of data that was captured) before handing off the payload.