On Fri, Feb 14, 2003 at 01:50:15PM +0100, Biot Olivier wrote:
> In attachment you'll find 2 patches that:
> - Move all static definitions from packet-wbxml.h to packet-wbxml.c
> - Uncomment inclusion of packet-wbxml.h in packet-wbxml.c
Presumably you meant "comment out".
I also fixed comments referring to packet-wbxml.h not to do so.
> - Append WBXML + version + public ID to the Info column
>
> If required, packet-wbxml.h can be removed altogether (I commented out the
> #include statement); however, it is safe to leave it there, might we want to
> export WBXML functionality in the future.
I've removed it - we can reinstate it if there's functionality that
needs to be exported via a header file (as opposed to, say, a dissector,
doesn't need a header file to be exported).
> I did *not* provide a patch to Makefile.am and Makefile.nmake in case we
> want to get rid of packet-wbxml.h from the file list.
Makefile.nmake didn't need a change.
> Please check in.
Done.
> PS thanks for the _U_ trick!
...which is no longer necessary, given
- Append WBXML + version + public ID to the Info column
as it's now using the "pinfo" argument.
