[Ethereal-dev] (no subject)

[packet steve]

When writing proto_register_xx, its easy to create unintended duplicates.

I’ve attached patches against 0.9.15 for
packet-dcerpc-rpriv.c
packet-dcerpc-spoolss.c
packet-isup.c
packet-nlsp.c
packet-ranap.c
packet-sua.c
to remove the exact duplicates I noticed.  Please consider these patches.

I noticed four other inexact duplicated &hf_xxx,
packet-fcdns.c    hf_fcdns_rply_fc4desc
packet-lmi.c      hf_lmi_inf_ele
packet-m3ua.c     hf_traffic_mode_type
packet-mysql.c    hf_mysql_error_code
E.g.,
packet-m3ua.c hf_traffic_mode_type,

{ &hf_traffic_mode_type, { "Traffic mode Type", "m3ua.traffic_mode_type", FT_UINT32, BASE_DEC, VALS(traffic_mode_type_values), 0x0, "", HFILL } },

{ &hf_traffic_mode_type, { "Traffic mode Type", "m3ua.traffic_mode_type", FT_UINT32, BASE_DEC, NULL, 0x0, "", HFILL } },

These are not identical. I suspect the second (without VALS) should be removed.

_________________________________________________________________
Help protect your PC. Get a FREE computer virus scan online from McAfee. http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

packet-dcerpc-rpriv.c
Description: Binary data

packet-dcerpc-spoolss.c

Description: Binary data


packet-isup.c

Description: Binary data


packet-nlsp.c

Description: Binary data


packet-ranap.c

Description: Binary data


packet-sua.c

Description: Binary data