Hi Chris, Could you generate an *unified* diff (diff -u) against the current CVS version? Your patch somehow gets mangled.
Regards, Olivier ----- Original Message ----- From: "Chris Wilson" | | Hi Olivier, | | On Tue, 27 Jan 2004 18:17:58 +0100 "Olivier Biot" wrote: | | > | Fix is: | > | | > | RCS file: /cvsroot/ethereal/packet-gsm_sms_ud.c,v | > | retrieving revision 1.3 | > | diff -r1.3 packet-gsm_sms_ud.c | > | 613a627,629 | > | > | > | > wsp_handle = find_dissector("wsp-cl"); | > | > g_assert (wsp_handle); | > | > Checked in, along with the removal of the email address as suggested | > by today's postings. | | Thanks. Latest mini-patch attached... | | It adds the option to prevent GSM SMS UD dissector allowing subdissectors to change the columns in the GUI. Reason for this, if I have a single TCP packet containing 4 Submit_sm's they'll be displayed as: | | PROTOCOL INFO | SMPP SMPP Submit_sm, Submit_sm, Submit_sm, Submit_sm | | However if the second Submit_sm is a WAP PUSH then the packet will show as: | | PROTOCOL INFO | WSP WSP Push (WBXML 1.2, Public ID: "-//WAPFORUM//DTD SI... | | And we'll lose the information in the INFO column about the other Submit_sm PDU's in the TCP packet. _______________________________________________ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.com/mailman/listinfo/ethereal-dev