Attached is another capture showing the problem with the decode. The first instance is packet 29, which contains two H.245 messages, the second of which is the UII.
Bryan -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 07, 2003 8:54 AM To: [EMAIL PROTECTED]; Ronnie Sahlberg; Bryan Pelham; [EMAIL PROTECTED] Subject: Re: Re: [Ethereal-users] Issue with decode of H.245 UserInputIndication -Malformed Packet Martin Regner wrote: >Ronnie Sahlberg wrote: > > Can you provide a capture showing the problem with the decode? > > > > > > > Trying out the new H.245 support in Ethereal 0.9.15 and may have found an > > > issue with the decoding of H.245 UserInputIndication messages (UII). The > > > decode reports a malformed packet: > > > > > > H.245 > > > MultimediaSystemControlMessage > > > PDU Type: .11. .... : Indication (3) > > > IndicationMessage > > > Indication Type: .... 1101 : UserInputIndication (13) > > > UserInputIndication > > > signal > > > UserInputIndication_signal > > > [Malformed Packet: H245] > > > > > > I believe the packet is correctly formed because the UII is successfully > > > decoded by the far end gateway. > > > > > > Yes there is a problem with Signal. Signal element is always an IA5 String with length 1, not a variable length. There is a fault in h245.c. > ooops ... not IA5String, but restricted character string > I can send a sample capture later on. I cannot find the capture right now. > > I sent a patch for solving this and some other issues a couple of weeks ago. Andreas Sikkema didn't have time to look at it at that time. > > Some part of my patch is not needed anymore, due to changes done by someone else (regarding NonStandardData). > > I'm out travelling right now, so I haven't been able to look more into the IA5String stuff that I tried to patch also with my patch. > I have attached a sample capture and a patch that I think will solve the problem (It�s one of the patches I sent a couple of weeks ago). /Martin
uui-malformed-packet.pcap
Description: Binary data
