On Mon, Nov 3, 2008 at 12:19 AM, Eric Wasylishen <[EMAIL PROTECTED]> wrote:
> Hey,
> Jesse suggested I write a short tutorial demonstrating Pragmatic
> Smalltalk used with Gorm. I've attached my tutorial attempt, for
> reviews / testing / suggestions before putting it on the website. :)

Very cool, that's an excellent initiative!

In the Step 1 section, I'd add a small shema showing the UI, the
MusicController instance, and the links between the UI and MusicController.
Explains/gives an example that clicking on the Skip button will, as
you connected them, send "skip:" message to the MusicController instance.

In Step 2, I'd give a quick overview of MusicController's role and functioning
-- the timer mechanism, what's inNewThread doing, etc.

Also, for the next three methods after timerEvent, I'd group
setPosition and skip together with a short descrition, then
show playFiles in its entirety followed by the additional explanations
you give (possibly quoting the lines again); cutting the methods in half
doesn't quite work here as the "code comment" text looks like the rest of
the documentation's text.

In the makefile, I'd maybe quickly list/explain the linked libs.

Finally, a couple of nitpicks:
- in timerEvent and setPosition, the brackets should be optional (e.g.
positionSlider setMaxValue: player duration.)
- in playFiles, maybe use a temp variable to hold the queue, and/or
indents the setQueue line. Also, you shouldn't need the final dot in
NSURL fileURLWithPath: path.

Great job !!

-- 
Nicolas Roard
"I love deadlines. I like the whooshing sound
they make as they fly by." -- Douglas Adams

_______________________________________________
Etoile-dev mailing list
Etoile-dev@gna.org
https://mail.gna.org/listinfo/etoile-dev

Reply via email to