Le 6 juin 09 à 20:09, Quentin Mathé a écrit :

> Le 3 juin 09 à 22:38, Truls Becken a écrit :
>
>> There is also one I did not include in the diff; ETUUID uses an
>> uninitialized variable on purpose to generate a random seed (as a
>> fallback in case /dev/random does not work). GCC 4.4 does not like
>> that.

There is no __attribute___((uninitialized)), so may be you can try to  
see whether a diagnostic pragma works. I mean something like:
#else
#pragma GCC diagnostic ignored "-Wuninitialized"
static void ETSRandomDev()
{
However I'm not sure this warning support to be tweaked with a pragma.  
If it isn't the case, we'll have to turn it off globally in Source/ 
GNUmakefile at least for platforms other than BSDs and Linux.

>> UKPluginsRegistry.m Languages/LanguageKit/CodeGen/CodeGenModule.h
>> Index: Frameworks/IconKit/Source/IKApplicationIconProvider.m
>> ===================================================================
>> [snip]
>>
>> Index: Frameworks/IconKit/Source/IKThumbnailProvider.m
>> ===================================================================
>> [snip]
>
> In the two previous cases, the correct fix is to assign what
> NSFileManager operation-related calls return to the 'result' variable.
> I'll fix that.
>
>> Index: Frameworks/EtoileFoundation/Source/UKPluginsRegistry.m
>> ===================================================================
>
> An assignment is missing here, this should be:
> image = [self loadIconForPath:iconPath];
> ^^^^^^^
> /* When image loading has failed, we set its value to null object in
> in order to be able to create info dictionary without glitches a 'nil'
> value would produce (like subsequent elements being ignored). */
> if (image == nil)
>       image = [NSNull null];
>
>>        /* We retrieve plugin's name */
>> Index: Languages/LanguageKit/CodeGen/CodeGenModule.h
>> ===================================================================
>> --- Languages/LanguageKit/CodeGen/CodeGenModule.h       (revision
>> 4747)
>> +++ Languages/LanguageKit/CodeGen/CodeGenModule.h       (working  
>> copy)
>> @@ -1,6 +1,7 @@
>> #ifndef __CODE_GEN_MODULE__INCLUDED__
>> #define __CODE_GEN_MODULE__INCLUDED__
>> #include "CGObjCRuntime.h"
>> +#include <stdio.h>
>>
>> namespace llvm {
>>  class BasicBlock;

I just committed these changes.

Thanks,
Quentin.
_______________________________________________
Etoile-dev mailing list
Etoile-dev@gna.org
https://mail.gna.org/listinfo/etoile-dev

Reply via email to