Hey Quentin,

> I'm not entirely convinced by this split, but I don't dislike it
> either :-)

Okay :) If we decide against this, an alternative that might be good
is using more descriptive names than 'Etoile' for additions to these:

NSIndexPath+Etoile
NSIndexSet+Etoile
NSInvocation+Etoile
NSString+Etoile
NSURL+Etoile

For example, it could be +Convenience.

>> EtoileFoundation:
>> ====================
>>
>> ETFilter
>
> I'm not sure this class will survive in its current state. It is not
> used anywhere currently.
> Feel free to move it to branches/Deprecated/EtoileFoundation.

I moved it to deprecated but then noticed that ETTransform is a
subclass of ETFilter, so I reverted the change.

>> ETException - not quite sure what this does.. will this be needed with
>> ObjC2 style exceptions?
>
> These are ObjC exception improvements. e.g. restartable exceptions.
> See David's paper: 
> <http://www.swan.ac.uk/compsci/research/reports/2008/CSR14-2008.pdf

Interesting, I need to read that some time.

>> ETHistoryManager
>
> I would also put ETHistoryManager with the core classes. I plan to use
> it in EtoileUI combined with ETPaneLayout to support navigational
> features.

Cool!

> I might miss something, but I think this class should really be named
> ETHistory and not ETHistoryManager. Each instance manage history
> entries and not histories, in other words each ETHistoryManager object
> just represents a simple history.
> For example,  in the WebKit there is WebHistory which contains
> WebHistoryItem as elements.
> imo manager classes should only be created when they have no specific
> corresponding names in the real-word.
>

Sounds good, I could rename it if you like.

>> NSFileManager+NameForTempFile
>> NSFileManager+TempFile
>
>One of these two implementations is deprecated and has to be removed,
>but several modules depend on the old implementation.

I could do this as well.


Does this set of classes look more sensible to move to a "Utilities"
(or maybe "Convenience") subproject?:

ETCArray
ETGetOptionsDictionary - function for processing command line args
ETTranscript - transcript for Smalltalk
NSFileManager+NameForTempFile
NSFileManager+TempFile
NSIndexPath+Etoile
NSIndexSet+Etoile
NSInvocation+Etoile - convenience factory method for NSInvocation
NSString+Etoile - some convenience methods for NSString
NSURL+Etoile - some convenience methods for NSURL

-Eric

_______________________________________________
Etoile-dev mailing list
Etoile-dev@gna.org
https://mail.gna.org/listinfo/etoile-dev

Reply via email to