Le 30 juin 09 à 18:15, Niels Grewe a écrit : > On Tue, Jun 30, 2009 at 01:35:43AM +0200, Quentin Mathé wrote: >> So I suggest to eliminate +mutableSubclass entirely and replace it >> with a new abstract method +mutableClass declared with >> NSObject(Etoile) and overriden in subclasses when that makes sense. > > Since it increases portability, I'm in favour of the change. > +mutableSubclass was more a quick pragmatic hack, after all.
ok. >> This patch adds +mutableClass to NSObject and all collection >> classes. It >> also makes the necessary updates in the HOM code to use this new >> method. >> All tests pass on Mac OS X with it. > > As you know your review inspired quite a few changes to the HOM > implementation. I think it might be the cleanest solution if you > committed this patch first, so that I can adopt my latest version to > use > +mutableClass prior to committing it. Yes. I just committed it with r4866. All test pass on GNUstep and Mac OS X / Cocoa. In case people want to play with HOM stuff or other EtoileFoundation things on Cocoa, EtoileUI Xcode project has two targets 'EtoileFoundation' and 'EtoileFoundationTests' to build the framework and run the test suite. The Xcode project itself is named Container.xcodeproj. I should really rename it :-) Cheers, Quentin. _______________________________________________ Etoile-dev mailing list Etoile-dev@gna.org https://mail.gna.org/listinfo/etoile-dev
