On Sat, Jul 11, 2009 at 02:05:08PM +0100, David Chisnall wrote: > The COREF_FROM_ID() macros should be being used everywhere to turn > pointers into CORefs. If it isn't being used somewhere, that's a > bug.
There were quite a few places in ETSerializer where it wasn't used. > For 32-bit, it's a simple cast, for 64-bit it should be calling > a function that looks up the object in the map. Okay, I now introduced a singleton managing a map table on 64bit. Is that reasonable? There seem be just enough management tasks (like setting up the map table and cleaning it up occasionally) to justify the encapsulation. A new diff is on the review board. This also fixes some other kinks (some enumerators weren't cleaned up properly, ESProxy was missing a -dealloc method) BTW: I really have to thank Eric for making that VirtualBox image available. Now I can finally test the stuff I write on 32bit in spite of my general laziness... Cheers Niels _______________________________________________ Etoile-dev mailing list Etoile-dev@gna.org https://mail.gna.org/listinfo/etoile-dev
