Hi Bill,

Thank you very much for a detailed list of steps to take! After we test your patch, we will let you know whether it works as expected :-).

Thanks once again!

Linda

On 11/9/20 9:24 PM, Bill Erickson wrote:
Hi Linda,

Here's another issue I can't really explain, but may have a fix if you are up for some experimentation.

I've noticed in the past, other i18n issues have been resolved by applying the i18n attribute in a more targeted fashion.  In the link you are having issues with has room for improvement in this regard.

1. Apply this patch: https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862 <https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862>

2. cd Open-ILS/src/eg2 ; npm run export-strings

3. Find the ID of the new "home" string in src/locale/messages.xmb.  It will look something like this:   <msg id="4976935068632868195"><source>app/staff/nav.component.html:9</source>home</msg>

4. Modify ./src/locale/messages.cs-CZ.xtb and change the ID of the broken home translation to this new ID and change the content of the translation to just the 'home' translation. Something like:

<translation id="NEW-ID-GOES-HERE">domů</translation>

5. Rebuild and deploy (npm run build-cs-CZ, etc.)

If this fixes it, I can push the patch to a LP entry.

Regarding your question about removing the tags in the translation, there will be drawbacks to doing that.  You'll need to leave those in place.  However, there are ways to reduce the occurrence of those types of control tags by using more targeted i18n attributes, but that comes at the cost (in some cases) of breaking up phrases and sentences into individual words, which could affect the meaning in translation.

Hope this helps / works,

-b




On Sat, Nov 7, 2020 at 5:14 AM Linda Jansová <[email protected] <mailto:[email protected]>> wrote:

    Dear all,

    In our 3.5 install, we have successfully managed to clean up the
    translation so that the open box characters do not appear
    alongside the proper translation. Thank you once again for
    providing guidance on how to correctly make the changes!

    The next issue we would like to tackle is the eg2 home icon and
    its accompanying (alternative) text.

    When the translation string is kept in its original format, only
    the "ů" letter shows up (instead of the graphical home icon with a
    full string which would read "domů" or "Domů").

    As can be seen at:

    
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c
    
<https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c>

    the translation string in question is this one:

    <translation id="3032413414186270145"> <ph
    name="START_TAG_SPAN"><ex>&lt;span&gt;</ex></ph>domů<ph
    name="CLOSE_TAG_SPAN"><ex>&lt;/span&gt;</ex></ph>

    ␣␣␣␣␣␣␣␣</translation>

    (The same translation string as currently included in Poeditor can
    be seen in the attached home_link_translation_in_poeditor.png file.)

    After we changed it (in our 3.5 install) to:

    <translation id="3032413414186270145">Domů</translation>

    we can see the full string "Domů" instead of just the last letter
    "ů" (please see the attached home_link_in_eg2.png screenshot).

    However, the home icon still seems to be missing from the
    translated interface.

    Is there a way to make it show up even in this non-English interface?

    And on a related note - could there be any drawbacks when the „<ph
    name="START_TAG_SPAN">“ etc. code is removed?

    Thank you in advance for any hints!

    Linda

    _______________________________________________
    Evergreen-general mailing list
    [email protected]
    <mailto:[email protected]>
    http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general
    <http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general>


_______________________________________________
Evergreen-general mailing list
[email protected]
http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general


_______________________________________________
Evergreen-general mailing list
[email protected]
http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general

Reply via email to