Could someone review my patch in http://bugzilla.gnome.org/show_bug.cgi?id=568593? I can commit if OK.

New files should be created with the default permissions for the user/system (respecting umask, and any setgid bit on the directory). The patch is trivial, using the new G_FILE_COPY_TARGET_DEFAULT_PERMS flag in glib 2.19.0.

- Mike



Index: libdocument/ev-file-helpers.c
===================================================================
--- libdocument/ev-file-helpers.c       (revision 3373)
+++ libdocument/ev-file-helpers.c       (working copy)
@@ -221,6 +221,9 @@
        target_file = g_file_new_for_uri (to);
        
        result = g_file_copy (source_file, target_file,
+#ifdef GLIB_CHECK_VERSION(2.19.0)
+                             G_FILE_COPY_TARGET_DEFAULT_PERMS |
+#endif
                              G_FILE_COPY_OVERWRITE,
                              NULL, NULL, NULL, &ioerror);

_______________________________________________
Evince-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/evince-list

Reply via email to