Thomas, please attach the patches to the corresponding bugs in bugzilla. We don't do reviews on the mailing list.
Thanks José On Sun, Mar 30, 2014 at 1:44 PM, Thomas Liebetraut <[email protected]>wrote: > Hi, > > On 19.03.2014 00:04, Thomas Liebetraut wrote: > > Anyway, I don't want to open this can of worms, so I'll follow my second > > proposal and add EvAnnotation* classes that correspond to the > > annotations supported by poppler 0.24 without trying to be smart about > > them and try to combine them to simpler "abstract" annotation types > > (like line, polygon and rect/circle annotations are all some sort of > > geometry annotation). > > Well, I digressed from this statement in the case of text markup > annotations, having only one class to implement them (but different _new > functions to set the appropriate annotation type). > > Other than that, the 6 attached patches implement an EvQuadrilateral > boxed type and a EvAnnotationTextMarkup class that makes use of it. The > last two patches finally implement highlight and strikethrough > annotations in the pdf backend and thus would close > <https://bugzilla.gnome.org/show_bug.cgi?id=583377>. > > Should I also attach these patches (even the first three which are only > infrastructure?) to this bug? > > The patches require the latest libpoppler-glib master -- more precisely > they require this commit: > < > http://cgit.freedesktop.org/poppler/poppler/commit/?id=ac3c8303396a0b8de5e4ad32f480b8da5f3b396e > >. > > > Thomas > > _______________________________________________ > evince-list mailing list > [email protected] > https://mail.gnome.org/mailman/listinfo/evince-list > >
_______________________________________________ evince-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/evince-list
