Oh, and fwiw, looking ahead, it may even be worth changing the public
API to take goffset's rather than off_t's if breaking API is acceptable
since it will prevent future off_t size issues (since I believe that
goffset is supposed to be an int64_t)

Jeff

On Mon, 2008-04-07 at 12:35 -0400, Jeffrey Stedfast wrote:
> I meant to keep it with the same defaults as before... did I goof? :(
> 
> The only 'gotcha' I can think of by enabling it by default is that it
> might break ABI if old builds were 32bit off_t's (the new off_t's would
> be 64bit).
> 
> I think the best coarse of action is to default it to the same off_t
> size as before (which, even if the old behavior was to enable largefile,
> since it was broken, might not have setup 64bit off_t's).
> 
> Jeff
> 
> On Mon, 2008-04-07 at 12:40 -0400, Matthew Barnes wrote:
> > On Mon, 2008-04-07 at 17:11 +0100, [EMAIL PROTECTED] wrote:
> > > Author: fejj
> > > Date: Mon Apr  7 17:11:40 2008
> > > New Revision: 8625
> > > URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=8625&view=rev
> > > 
> > > Log:
> > > 2008-04-07  Jeffrey Stedfast  <[EMAIL PROTECTED]>
> > > 
> > >   * configure.in: Do proper checks for largefile support and
> > >   properly setup proper CFLAGS to support it.
> > > 
> > 
> > ´╗┐Hey Jeff,
> > 
> > Just curious why you chose to disable this by default.  Seems like we'd
> > want to take advantage of largefile support if it's available, or are
> > there undesirable tradeoffs involved?
> > 
> > Matthew Barnes
> > 
> 
> _______________________________________________
> Evolution-hackers mailing list
> Evolution-hackers@gnome.org
> http://mail.gnome.org/mailman/listinfo/evolution-hackers

_______________________________________________
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers

Reply via email to