Am Donnerstag, den 15.08.2013, 07:47 +0200 schrieb Thomas Mittelstaedt: > I made a couple of changes to my ancient (2.28.4) version of evolution. > First, I encountered a nuisance in the alarm notify dialog, that when > the dialog pops up and a new alarm is coming in, the selection changes > to this new item, while the user potentially ist just clicking the > dismiss or snooze button. I made the attached change to simply not > preselect anything, having checked that the same is still running in the > current git version at https://git.gnome.org/browse/evolution. > > I also had a crash in the alarm-notify app and I inserted the attached > safety check. > > > > _______________________________________________ > evolution-hackers mailing list > evolution-hackers@gnome.org > To change your list options or unsubscribe, visit ... > https://mail.gnome.org/mailman/listinfo/evolution-hackers
Also make another change to show a confirmation dialog when the user presses the "dismiss all" button. -- thomas
commit 8db79a84f68f32f07be4c139cdb4f9721d43ef0c Author: Thomas Mittelstaedt <tmsta...@t-mittelstaedt.de> Date: Fri Aug 16 05:07:11 2013 +0200 Show a confirmation dialog, when the user presses the dismiss all button. diff --git a/calendar/gui/alarm-notify/alarm-queue.c b/calendar/gui/alarm-notify/alarm-queue.c index 59a0884..b29b8ac 100644 --- a/calendar/gui/alarm-notify/alarm-queue.c +++ b/calendar/gui/alarm-notify/alarm-queue.c @@ -1177,6 +1177,9 @@ tray_list_remove_data (TrayIconData *data) message_push ((Message *) msg); } +static gboolean +procedure_notification_dialog (const gchar *cmd, const gchar *url); + static void notify_dialog_cb (AlarmNotifyResult result, gint snooze_mins, gpointer data) { @@ -1232,7 +1235,7 @@ notify_dialog_cb (AlarmNotifyResult result, gint snooze_mins, gpointer data) case ALARM_NOTIFY_CLOSE: d(printf("%s:%d (notify_dialog_cb) - Dialog close\n",__FILE__, __LINE__)); - if (alarm_notifications_dialog) { + if (alarm_notifications_dialog && procedure_notification_dialog ("Sure close?", "")) { GtkTreeIter iter; GtkTreeModel *model = gtk_tree_view_get_model (
_______________________________________________ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers