[Evolution-hackers] Re: seeking review for bug 44862:

[Yuedong Du]

Yes, I like this way. So I'll send you each patch for review instead of merge all of them at once. And commited this patch. Radek Doulík wrote: Hi York, I think it's no problem. I only wonder if you want to cross a11y branch with HEAD like this. I guess it can complicate a bit final merge of a11y branch. Probably not a big issue anyway. Cheers Radek On Tue, 2003-07-22 at 12:03, Yuedong Du wrote: Radek and all, The patch is only commited into a11y branch. Now can I commited into HEAD, is it OK? York yuedong du wrote: On Thu, 2003-06-19 at 22:41, Radek Doul铆k wrote: Hi York, thank you very much for this patch. It looks OK to me. I only wonder when o is NULL at that place: @@ -88,6 +89,8 @@ html_utils_get_accessible (HTMLObject *o, AtkObject *parent) { AtkObject *accessible; + + if (!o) return NULL; accessible = html_object_get_data (o, ACCESSIBLE_ID); Do you know when is it called with NULL object and why? I would rather like to see g_return_val_if_fail (o != NULL, NULL); at that place. I dunno when it happens though. Sorry, I have forgot when and where it crash. But it is no harm to do so. Commit this patch in a11y-branch. Cheers Radek