On Thu, 2004-01-15 at 17:45, JP Rosevear wrote:
> On Tue, 2004-01-13 at 12:40, Mark McLoughlin wrote:
> > Index: libedataserver/e-source.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution-data-server/libedataserver/e-source.c,v
> > retrieving revision 1.11
> > diff -u -p -r1.11 e-source.c
> > --- libedataserver/e-source.c 9 Jan 2004 20:05:34 -0000 1.11
> > +++ libedataserver/e-source.c 13 Jan 2004 17:33:57 -0000
> > @@ -622,7 +622,7 @@ dump_common_to_xml_node (ESource *source
> > ESourcePrivate *priv;
> > gboolean has_color;
> > guint32 color;
> > - xmlNodePtr node, properties_node;
> > + xmlNodePtr node;
> >
> > priv = source->priv;
> >
> > @@ -642,8 +642,12 @@ dump_common_to_xml_node (ESource *source
> > g_free (color_string);
> > }
> >
> > - properties_node = xmlNewChild (node, NULL, "properties", NULL);
> > - g_hash_table_foreach (priv->properties, (GHFunc) property_dump_cb,
> > properties_node);
> > + if (g_hash_table_size (priv->properties) != 0) {
> > + xmlNodePtr properties_node;
> > +
> > + properties_node = xmlNewChild (node, NULL, "properties", NULL);
> > + g_hash_table_foreach (priv->properties, (GHFunc) property_dump_cb,
> > properties_node);
> > + }
>
> What is the point of this change?
Slightly reduces the amount of XML dumped in GConf in the common case.
Not exactly an important change, just something I noticed while
tracking down some other problems I was seeing in this area.
Cheers,
Mark.
_______________________________________________
evolution-hackers maillist - [EMAIL PROTECTED]
http://lists.ximian.com/mailman/listinfo/evolution-hackers
