On Fri, 2005-06-17 at 16:42 -0700, Nathan Owens wrote: > This is in regard to bug 201167 > (http://bugzilla.gnome.org/show_bug.cgi?id=201167) > > I submitted a patch for people to look at regarding todo-conduit category > syncing, and haven't heard anything. Should I assume people like it?
Where did you submit? The bug system only? They should normally be sent to evolution-patches (with a link to the bug at least, dont need to include the attachment). Although having said that, nobody ever seems to care to review anything other than mail patches in a very timely manner anyway. > Anyway, I found a bug in the code: it was possible for a NULL pointer to be > dereferenced. Attached is an updated patch against the latest CVS version. > Should I send this to evolution-patches as well? No need to this time, i think this should suffice for now, updates should go there though, It is quite a large patch - you will need copyright assignment (see the gnome evolution development pages i guess? sigh i wish we didn't need this red tape). And please read the HACKING file, the style of the new code is also incorrect, missing changelogs, etc. > The category listeners still aren't working, but it's not my code causing this > as none of the other category listeners employed in the tasks component code > work either. Ok, hopefully someone who knows can review the logic. Otherwise give it a week and assuming other things above are done, poke again, and i'll give it a once over and probably accept it. Thanks though! Michael _______________________________________________ evolution-hackers maillist - [email protected] http://lists.ximian.com/mailman/listinfo/evolution-hackers
