More comments
>---
>diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c
>--- NULL 1969-12-31 18:00:00.000000000 -0600
>+++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c 2007-08-06
>20:09:04.000000000 -0500
>+
>+#include "nes.h"
>+u32 crit_err_count = 0;
Possible global namespace conflict. You should make sure all global
symbols start with something specfic to driver like "nes_".
>+#include "nes_cm.h"
>+
>+
>+#ifdef NES_DEBUG
>+static unsigned char *nes_iwarp_state_str[] = {
Why use unsigned char? This should be "static const char *"
Maybe use gcc array initilaizers.
_______________________________________________
ewg mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
