> Quoting Erez Zilber <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] stop OFED before uninstalling it > > Tziporet Koren wrote: > > > Erez Zilber wrote: > >> stop OFED before uninstalling it > >> > >> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]> > >> --- > >> uninstall.sh | 5 +++++ > >> 1 files changed, 5 insertions(+), 0 deletions(-) > >> > >> diff --git a/uninstall.sh b/uninstall.sh > >> index 177b8a1..89ee3f1 100755 > >> --- a/uninstall.sh > >> +++ b/uninstall.sh > >> @@ -110,6 +110,11 @@ uninstall() > >> { > >> local RC=0 > >> local OLD_PREFIX="" > >> + > >> + echo "Stopping OFED stack" > >> + echo > >> + /etc/init.d/openibd stop > >> + > >> echo > >> echo "Removing ${PACKAGE} Software installations" > >> echo > >> > > > > What would the install do if this is failing or machine hang? > > > > Tziporet > > > > The user will have to stop OFED at some point. If we don't stop OFED > while uninstalling, he will stop it later (and then the machine may hang). > > The motivation for this patch is: if the user installs OFED over an > older version (while the old version is running), he will eventually > have a new version of OFED installed with an old loaded version. This > may lead to strange scenarios. For example: if the user tries to load > iSER, modprobe will fail because iSER (from the new OFED version) cannot > use the loaded OFED modules (from the old version). Of course, this can > happen with any OFED module. > > Actually, this fix is related to bug #536. Maybe we should move this > discussion to bugzilla.
NAK. This would break e.g. systems which rely on ipoib for connectivity. iSER failing with clear version conflict message seems like a minor problem. How about just documenting this? How about producing a message telling the user to reboot? -- MST _______________________________________________ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg